Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnConfigurationWindowClosed Event #415

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

searica
Copy link
Contributor

@searica searica commented Nov 8, 2023

I wanted to add an event that triggers when the in-game configuration manager window is closed because I realized that probablykory and I likely aren't the only ones who use the window closing as a way to trigger updating mods after configuration settings have been changed. Plus having an event for it in Jotunn would be quite convenient and reduce the amount of boilerplate code needed to set up the event in each mod I make.

Since this would be a feature that is mostly used for local management of configuration files I don't know if adding the event to the SynchronizationManager class is the most appropriate place for it or not? This was the easiest place to add the event though as the code in it already checks for the configuration manager window closing.

@MSchmoecker
Copy link
Member

Thanks, looks good. Yes adding the event to the SynchronizationManager is fitting, since it's about configuration.

@MSchmoecker MSchmoecker merged commit 231bd2f into Valheim-Modding:dev Nov 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants